Retain name and propertyName in declaration emit copies of binding patterns if property name is a keyword#50537
Merged
weswigham merged 3 commits intoAug 30, 2022
Conversation
…tterns if property name is a keyword
typescript-bot
added
Author: Team
For Milestone Bug
jakebailey
reviewed
Aug 30, 2022
Member
|
LGTM besides the old checked in file. Sorry about that; I considered leaving it gitignored for a while after I removed it so it'd be harder to do that, but decided against it. |
Member
Author
|
cc @RyanCavanaugh to follow |
Contributor
|
Heya @weswigham, I've started to run the task to cherry-pick this into |
Contributor
|
Hey @weswigham, I've opened #50538 for you. |
andrewbranch
approved these changes
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50483